CASSANDRA-20982: Restrict BytesType value compatibility to scalar types, exclude collections and UDTs #4439
Conversation
BytesType.isValueCompatibleWith() previously accepted all types, including frozen collections and UDTs. This was incorrect because converting collections or UDTs to raw bytes is nonsensical - it allows reading raw serialized bytes which have no meaningful interpretation. This patch restricts BytesType to only accept simple scalar types by checking !isCollection() && !isUDT() in isValueCompatibleWithInternal(). patch by Dekrate for CASSANDRA-20982
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java
Outdated
Show resolved
Hide resolved
Replace isCollection() && isUDT() checks with isMultiCell() for cleaner code. Update error message in AlterTableStatement to more clearly indicate that we're adding a column of incompatible type with a previously dropped column, rather than suggesting the dropped column had the new type. Update tests to match the new error message format. patch by Dekrate for CASSANDRA-20982
|
@smiklosovic, done |
| return true; | ||
| // BytesType should only be compatible with simple scalar types, not with collections or UDTs | ||
| // because converting a collection or UDT to raw bytes is nonsensical | ||
| return !otherType.isMultiCell(); |
There was a problem hiding this comment.
Doing this here will break cql CAST operations, which I think we still might want to allow since they are explicit, and different from finding a column you re-added contains junk bytes.
Also, isMultiCell will return false for frozen collections.
There was a problem hiding this comment.
@driftx, should I revert to the first version?
return !otherType.isCollection() && !otherType.isUDT();
There was a problem hiding this comment.
Yes and we shouldn't do this in isValueCompatibleWithInternal since it will prevent CASTing to bytes.
There was a problem hiding this comment.
@driftx, thanks! Could you please suggest any particular place to put it in?
To sum up:
isValueCompatibleWithInternalreturns true backreturn !otherType.isCollection() && !otherType.isUDT();will be in the other place?
There was a problem hiding this comment.
Maybe this isSerializationCompatibleWith?
There was a problem hiding this comment.
isSerializationCompatibleWith will prevent the schema change but still allow the cast.
3 participants
Restrict BytesType compatibility to scalar types only
BytesType.isValueCompatibleWith() previously accepted all types,
including frozen collections and UDTs. This was incorrect because
converting collections or UDTs to raw bytes is nonsensical - it
allows reading raw serialized bytes which have no meaningful
interpretation.
This patch restricts BytesType to only accept simple scalar types
by checking !isCollection() && !isUDT() in isValueCompatibleWithInternal().
@driftx <- it was your task, I was happy to help!